Ben Kraft
3a5bf46da4
## Summary: If your type implements an interface, we add getter methods for the shared fields, so that those may be accessed via the interface. But it turns out occasionally it's useful to have these getter methods when they don't implement a GraphQL interface, so you can use two genqlient-generated types in the same function if they have the same fields. (This comes up most often when you have a GraphQL union that maybe should really be an interface, or if you don't yet support interfaces implementing other interfaces (indeed our parser doesn't either). But one can imagine other use cases.) We can't predict how you want to do that, so we can't generate the interface, but we can generate the methods, so you can define the interface and do a type assertion from there. Since these methods are pretty simple to generate, we just do it always. (As with #120, if binary size becomes an issue we could later add an option to only generate methods that are truly needed but including them seems like the better default.) This also fixes a subtle and rare bug, which would have become much more common (indeed existing tests caught it). Specifically, if you have a query like ```graphql fragment FragmentOne on T { id } fragment FragmentTwo on T { id } query Q { f { # interface type T ...FragmentOne ...FragmentTwo } } ``` since both `FragmentOne` and `FragmentTwo` request some common field, say `id`, we generate a method `GetId` on each one. But since `FragmentOne` and `FragmentTwo` are both on `T`, we also include their interfaces in the interface we generate for the type of `f`, `QFT`. So `QFT` includes a method `GetId`. But on the implementations, the two methods conflict, and neither gets promoted; this causes various code to fail to compile. With this change, this would have happened much more frequently -- even if only one of the two fragments is on `T`, as long as both request the field. Anyway, we now generate explicit methods on each struct for all of its recursively emebedded fields -- using the logic from #120 to compute them -- so that we don't need to rely on method-promotion. ## Test plan: make tesc Author: benjaminjkraft Reviewers: csilvers, dnerdy, aberkan, jvoll, mahtabsabet, MiguelCastillo, StevenACoffman Required Reviewers: Approved By: csilvers, dnerdy Checks: ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint, ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint Pull Request URL: https://github.com/Khan/genqlient/pull/126
124 lines
3.3 KiB
Go
124 lines
3.3 KiB
Go
package main
|
|
|
|
// Code generated by github.com/Khan/genqlient, DO NOT EDIT.
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/Khan/genqlient/graphql"
|
|
)
|
|
|
|
// __getUserInput is used internally by genqlient
|
|
type __getUserInput struct {
|
|
Login string `json:"Login"`
|
|
}
|
|
|
|
// GetLogin returns __getUserInput.Login, and is useful for accessing the field via an interface.
|
|
func (v *__getUserInput) GetLogin() string { return v.Login }
|
|
|
|
// getUserResponse is returned by getUser on success.
|
|
type getUserResponse struct {
|
|
// Lookup a user by login.
|
|
User getUserUser `json:"user"`
|
|
}
|
|
|
|
// GetUser returns getUserResponse.User, and is useful for accessing the field via an interface.
|
|
func (v *getUserResponse) GetUser() getUserUser { return v.User }
|
|
|
|
// getUserUser includes the requested fields of the GraphQL type User.
|
|
// The GraphQL type's documentation follows.
|
|
//
|
|
// A user is an individual's account on GitHub that owns repositories and can make new content.
|
|
type getUserUser struct {
|
|
// The user's public profile name.
|
|
TheirName string `json:"theirName"`
|
|
// Identifies the date and time when the object was created.
|
|
CreatedAt time.Time `json:"createdAt"`
|
|
}
|
|
|
|
// GetTheirName returns getUserUser.TheirName, and is useful for accessing the field via an interface.
|
|
func (v *getUserUser) GetTheirName() string { return v.TheirName }
|
|
|
|
// GetCreatedAt returns getUserUser.CreatedAt, and is useful for accessing the field via an interface.
|
|
func (v *getUserUser) GetCreatedAt() time.Time { return v.CreatedAt }
|
|
|
|
// getViewerResponse is returned by getViewer on success.
|
|
type getViewerResponse struct {
|
|
// The currently authenticated user.
|
|
Viewer getViewerViewerUser `json:"viewer"`
|
|
}
|
|
|
|
// GetViewer returns getViewerResponse.Viewer, and is useful for accessing the field via an interface.
|
|
func (v *getViewerResponse) GetViewer() getViewerViewerUser { return v.Viewer }
|
|
|
|
// getViewerViewerUser includes the requested fields of the GraphQL type User.
|
|
// The GraphQL type's documentation follows.
|
|
//
|
|
// A user is an individual's account on GitHub that owns repositories and can make new content.
|
|
type getViewerViewerUser struct {
|
|
// The user's public profile name.
|
|
MyName string `json:"MyName"`
|
|
// Identifies the date and time when the object was created.
|
|
CreatedAt time.Time `json:"createdAt"`
|
|
}
|
|
|
|
// GetMyName returns getViewerViewerUser.MyName, and is useful for accessing the field via an interface.
|
|
func (v *getViewerViewerUser) GetMyName() string { return v.MyName }
|
|
|
|
// GetCreatedAt returns getViewerViewerUser.CreatedAt, and is useful for accessing the field via an interface.
|
|
func (v *getViewerViewerUser) GetCreatedAt() time.Time { return v.CreatedAt }
|
|
|
|
func getViewer(
|
|
ctx context.Context,
|
|
client graphql.Client,
|
|
) (*getViewerResponse, error) {
|
|
var err error
|
|
|
|
var retval getViewerResponse
|
|
err = client.MakeRequest(
|
|
ctx,
|
|
"getViewer",
|
|
`
|
|
query getViewer {
|
|
viewer {
|
|
MyName: name
|
|
createdAt
|
|
}
|
|
}
|
|
`,
|
|
&retval,
|
|
nil,
|
|
)
|
|
return &retval, err
|
|
}
|
|
|
|
// getUser gets the given user's name from their username.
|
|
func getUser(
|
|
ctx context.Context,
|
|
client graphql.Client,
|
|
Login string,
|
|
) (*getUserResponse, error) {
|
|
__input := __getUserInput{
|
|
Login: Login,
|
|
}
|
|
var err error
|
|
|
|
var retval getUserResponse
|
|
err = client.MakeRequest(
|
|
ctx,
|
|
"getUser",
|
|
`
|
|
query getUser ($Login: String!) {
|
|
user(login: $Login) {
|
|
theirName: name
|
|
createdAt
|
|
}
|
|
}
|
|
`,
|
|
&retval,
|
|
&__input,
|
|
)
|
|
return &retval, err
|
|
}
|