Ben KraftandGitHub
8de55d352e
## Summary: This is useful if you want to bind to a type you don't control (or use for other things) but need different serialization than its default. This is a feature gqlgen has and we've found it very useful. For example, in webapp we want to bind `DateTime` to `time.Time`, but its default serialization is not compatible with Python, so currently we have to bind to a wrapper type and cast all over the place, which is exactly the sort of boilerplate genqlient is supposed to avoid. For unmarshaling, the implementation basically just follows the existing support for abstract types; instead of calling our own generated helper, we now call your specified function. This required some refactoring to abstract the handling of custom unmarshalers generally from abstract types specifically, and to wire in not only the unmarshaler-name but also the `generator` (in order to compute the right import alias). For marshaling, I had to implement all that stuff over again; it's mostly parallel to unmarshaling (and I made a few minor changes to unmarshaling to make the two more parallel). Luckily, after #103 I at least only had to do it once, rather than implementing the same functionality for arguments and for input-type fields. It was still quite a bit of code; I didn't try to be quite as completionist about the tests as with unmarshal but still had to add a few. Issue: https://github.com/Khan/genqlient/issues/38 ## Test plan: make check Author: benjaminjkraft Reviewers: StevenACoffman, dnerdy, benjaminjkraft, aberkan, jvoll, mahtabsabet, MiguelCastillo Required Reviewers: Approved By: StevenACoffman, dnerdy Checks: ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint, ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint Pull Request URL: https://github.com/Khan/genqlient/pull/104
35 lines
1.4 KiB
Go
35 lines
1.4 KiB
Go
package graphql
|
|
|
|
// Utility types used by the generated code. In general, these are *not*
|
|
// intended for end-users.
|
|
|
|
// NoUnmarshalJSON is intended for the use of genqlient's generated code only.
|
|
//
|
|
// It is used to prevent a struct type from inheriting its embed's
|
|
// UnmarshalJSON method, so if we construct a type:
|
|
// type T struct { E; NoUnmarshalJSON }
|
|
// where E has an UnmarshalJSON method, T will not inherit it, per the Go
|
|
// selector rules: https://golang.org/ref/spec#Selectors.
|
|
type NoUnmarshalJSON struct{}
|
|
|
|
// UnmarshalJSON should never be called; it exists only to prevent a sibling
|
|
// UnmarshalJSON method from being promoted.
|
|
func (NoUnmarshalJSON) UnmarshalJSON(b []byte) error {
|
|
panic("NoUnmarshalJSON.UnmarshalJSON should never be called!")
|
|
}
|
|
|
|
// NoMarshalJSON is intended for the use of genqlient's generated code only.
|
|
//
|
|
// It is used to prevent a struct type from inheriting its embed's
|
|
// MarshalJSON method, so if we construct a type:
|
|
// type T struct { E; NoMarshalJSON }
|
|
// where E has an MarshalJSON method, T will not inherit it, per the Go
|
|
// selector rules: https://golang.org/ref/spec#Selectors.
|
|
type NoMarshalJSON struct{}
|
|
|
|
// MarshalJSON should never be called; it exists only to prevent a sibling
|
|
// MarshalJSON method from being promoted.
|
|
func (NoMarshalJSON) MarshalJSON() ([]byte, error) {
|
|
panic("NoUnmarshalJSON.MarshalJSON should never be called!")
|
|
}
|