From bf266d874dfeba49d676bcc8334f60574cbc0b2e Mon Sep 17 00:00:00 2001 From: Ben Kraft Date: Thu, 26 Aug 2021 14:35:54 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9F=94=A5AUDIT=F0=9F=94=A5]=20Mark=20interf?= =?UTF-8?q?aces=20as=20enabled!=20(#67)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🖍 _This is an audit!_ 🖍 ## Summary: We've completed support for interfaces! Fragments are still pending, but interfaces by themselves should be usable. But I forgot to actually remove the flag they were behind. In this commit I do! Issue: https://khanacademy.slack.com/archives/C01120CNCS0/p1630012808004100 ## Test plan: make check Author: benjaminjkraft Auditors: aberkan, csilvers, dnerdy, MiguelCastillo Required Reviewers: Approved by: Checks: ⌛ Test (1.17), ⌛ Test (1.16), ⌛ Test (1.15), ⌛ Test (1.14), ⌛ Test (1.13), ⌛ Lint, ⌛ Test (1.17), ⌛ Test (1.16), ⌛ Test (1.15), ⌛ Test (1.14), ⌛ Test (1.13), ✅ Lint Pull request URL: https://github.com/Khan/genqlient/pull/67 --- generate/convert.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/generate/convert.go b/generate/convert.go index c86780f..ca3701d 100644 --- a/generate/convert.go +++ b/generate/convert.go @@ -256,10 +256,6 @@ func (g *generator) convertDefinition( return goType, nil case ast.Interface, ast.Union: - if !g.Config.AllowBrokenFeatures { - return nil, errorf(pos, "not implemented: %v", def.Kind) - } - implementationTypes := g.schema.GetPossibleTypes(def) goType := &goInterfaceType{ GoName: name,