From af5d1bd5422ba29412c478a99ed84a32880d572c Mon Sep 17 00:00:00 2001 From: Ben Kraft Date: Fri, 27 Mar 2020 18:01:56 -0700 Subject: [PATCH] lowercase for arguments --- example/generated.go | 6 +++--- example/queries.graphql | 4 ++-- generate/generate.go | 8 +++++--- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/example/generated.go b/example/generated.go index 4670770..d72e24e 100644 --- a/example/generated.go +++ b/example/generated.go @@ -35,13 +35,13 @@ type getUserResponse = struct { // getUser gets the given user's name from their username. func getUser(ctx context.Context, client *graphql.Client, login string) (*getUserResponse, error) { variables := map[string]interface{}{ - "login": login, + "Login": login, } var retval getUserResponse err := client.MakeRequest(ctx, ` -query getUser ($login: String!) { - user(login: $login) { +query getUser ($Login: String!) { + user(login: $Login) { theirName: name } } diff --git a/example/queries.graphql b/example/queries.graphql index 3237e43..b7b2cc4 100644 --- a/example/queries.graphql +++ b/example/queries.graphql @@ -5,8 +5,8 @@ query getViewer { } # getUser gets the given user's name from their username. -query getUser($login: String!) { - user(login: $login) { +query getUser($Login: String!) { + user(login: $Login) { theirName: name } } diff --git a/generate/generate.go b/generate/generate.go index 9521e52..f8d8472 100644 --- a/generate/generate.go +++ b/generate/generate.go @@ -52,11 +52,13 @@ type argument struct { } func fromASTArg(arg *ast.VariableDefinition, schema *ast.Schema) argument { + graphQLName := arg.Variable + firstRest := strings.SplitN(graphQLName, "", 2) + goName := strings.ToLower(firstRest[0]) + firstRest[1] return argument{ - GraphQLName: arg.Variable, - GoName: arg.Variable, // TODO: normalize this to go-style + GraphQLName: graphQLName, + GoName: goName, GoType: typeForInputType(arg.Type, schema), - // TODO: figure out what to do about defaults } }