talksik/genqlient
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Support package-names with dashes in them (#232)

Browse Source 
Support package-names with dashes in them

We were smart about aliasing if you have name-collisions, but not if
your package name is something that's not a valid identifier, like
`"path/to/my-package"`, which Go for better or worse allows. Now we
remove all the invalid characters (in practice mainly dashes, dots, and
leading digits).

Fixes #231.

Test plan: make check
This commit is contained in:
Ben Kraft
2022-11-09 09:43:04 -08:00
committed by GitHub
parent 1d71fffcb6
commit 80687e7336
6 changed files with 197 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/CHANGELOG.md
+2 -1
View File
@@ -28,7 +28,8 @@ When releasing a new version:
### Bug fixes:
- Fixed non-deterministic generated code when querying graphql interfaces
- Fixed non-deterministic generated code when querying graphql interfaces.
- Fixed generated code when last component of package name is not a valid identifier (e.g. `"path/to/my-package"`).
## v0.5.0