Enable golangci-lint (#49)

## Summary:
It would be nice to have some linting beyond `go vet`!  Now we do.  I
started by copying the config from Khan/webapp.  I did remove a couple
of staticcheck checks that I didn't feel were useful.  (Note also that
exportloopref is the replacement for scopelint in newer golangci-lint.)

Included are all the needed lint fixes; most are stylistic but the
changes in the example are a (minor) bugfix.

Fixes #22.
Issue: https://github.com/Khan/genqlient/issues/22

## Test plan:
make check

Author: benjaminjkraft

Reviewers: aberkan, dnerdy, benjaminjkraft, csilvers, MiguelCastillo

Required Reviewers: 

Approved by: aberkan, dnerdy

Checks: ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Test (1.13), ✅ Lint, ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Test (1.13), ✅ Lint

Pull request URL: https://github.com/Khan/genqlient/pull/49

This commit is contained in:

Ben Kraft

2021-08-20 10:39:12 -07:00

committed by

GitHub

parent 832c0bf855

commit 700392315a

16 changed files with 1338 additions and 26 deletions

									
										Makefile
									
		+1
		
												View File
												
				@@ -3,6 +3,7 @@ example:

					go run ./example/cmd/example/main.go

				check:

					go run github.com/golangci/golangci-lint/cmd/golangci-lint run ./...

					go test -cover ./...

				genqlient.png: genqlient.svg