Picking some nits that my IDE complained about (#91)
* Picking some nits that my IDE complained about Signed-off-by: Steve Coffman <[email protected]> * Update graphql/util.go Co-authored-by: Ben Kraft <[email protected]> * revert to original for comment Signed-off-by: Steve Coffman <[email protected]> Co-authored-by: Ben Kraft <[email protected]>
This commit is contained in:
co-authored by
Ben Kraft
parent
639b46df32
commit
673840e495
+2
-2
@@ -90,7 +90,7 @@ func (g *generator) convertInputType(
|
||||
options, queryOptions *genqlientDirective,
|
||||
) (goType, error) {
|
||||
// note prefix is ignored here (see generator.typeName), as is selectionSet
|
||||
// (for input types we use the whole thing)).
|
||||
// (for input types we use the whole thing).
|
||||
return g.convertType(nil, typ, nil, options, queryOptions)
|
||||
}
|
||||
|
||||
@@ -463,7 +463,7 @@ func (g *generator) convertInlineFragment(
|
||||
containingTypedef *ast.Definition,
|
||||
queryOptions *genqlientDirective,
|
||||
) ([]*goStructField, error) {
|
||||
// You might think fragmentTypedef would be fragment.ObjectDefinition, but
|
||||
// You might think fragmentTypedef would be a fragment.ObjectDefinition, but
|
||||
// actually that's the type into which the fragment is spread.
|
||||
fragmentTypedef := g.schema.Types[fragment.TypeCondition]
|
||||
if !fragmentMatches(containingTypedef, fragmentTypedef) {
|
||||
|
||||
@@ -18,7 +18,7 @@ type descriptionInfo struct {
|
||||
CommentOverride string
|
||||
// name of the corresponding GraphQL type
|
||||
GraphQLName string
|
||||
// GraphQL description of the type .GraphQLName, if any
|
||||
// GraphQL schema's description of the type .GraphQLName, if any
|
||||
GraphQLDescription string
|
||||
// name of the corresponding GraphQL fragment (on .GraphQLName), if any
|
||||
FragmentName string
|
||||
|
||||
+1
-1
@@ -245,7 +245,7 @@ func (typ *goInterfaceType) WriteDefinition(w io.Writer, g *generator) error {
|
||||
"Get%s is a part of, and documented with, the interface %s.",
|
||||
sharedField.GoName, typ.GoName)
|
||||
writeDescription(w, description)
|
||||
// In principle we should find the corresponding field of the
|
||||
// In principle, we should find the corresponding field of the
|
||||
// implementation and use its name in `v.<name>`. In practice,
|
||||
// they're always the same.
|
||||
fmt.Fprintf(w, "func (v *%s) Get%s() %s { return v.%s }\n",
|
||||
|
||||
Reference in New Issue
Block a user