talksik/genqlient
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PR 239 update: Adding more logging for the initial generate setup (#246)

Browse Source 
This is just a tweak to #239 to update the snapshots.
I have:
- [X] Written a clear PR title and description (above)
- [X] Signed the [Khan Academy CLA](https://www.khanacademy.org/r/cla)
- [X] Added tests covering my changes, if applicable
- [X] Included a link to the issue fixed, if applicable
- [X] Included documentation, for new features
- [ ] Added an entry to the changelog

Signed-off-by: Steve Coffman <[email protected]>
Co-authored-by: Sam Wallace <[email protected]>
This commit is contained in:
Steve Coffman
2022-12-22 11:36:08 -05:00
committed by GitHub
co-authored by Sam Wallace
parent b1adeca6da
commit 596c33f0b0
4 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
generate/config.go
+6 -2
View File
@@ -102,12 +102,16 @@ func (c *Config) ValidateAndFillDefaults(baseDir string) error {
if c.Package == "" {
abs, err := filepath.Abs(c.Generated)
if err != nil {
return errorf(nil, "unable to guess package-name: %v", err)
return errorf(nil, "unable to guess package-name: %v is not a valid identifier"+
"\nSet package name in genqlient.yaml"+
"\nExample: https://github.com/Khan/genqlient/blob/main/example/genqlient.yaml#L6", err)
}
base := filepath.Base(filepath.Dir(abs))
if !token.IsIdentifier(base) {
return errorf(nil, "unable to guess package-name: %v is not a valid identifier", base)
return errorf(nil, "unable to guess package-name: %v is not a valid identifier"+
"\nSet package name in genqlient.yaml"+
"\nExample: https://github.com/Khan/genqlient/blob/main/example/genqlient.yaml#L6", base)
}
c.Package = base