From 288657fcb9d51d59c3883050f35cfdbbe399796b Mon Sep 17 00:00:00 2001 From: Ben Kraft Date: Fri, 16 Apr 2021 11:55:35 -0700 Subject: [PATCH] TODOs --- README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index dcbf208..d0c2300 100644 --- a/README.md +++ b/README.md @@ -109,7 +109,7 @@ Generated code customization: Config options: - proper config/arguments setup (e.g. with [viper](https://github.com/spf13/viper)) -- (+) improve client_getter to be more usable (and document it), or flag it out for now. +- (+) improve client_getter to be more usable (and document it), maybe by just saying it has to be a function that takes context, or flag it out for now. - get schema via GraphQL introspection (although honestly, it seems like SDL is becoming popular enough there may be no need) - whether names should be exported - default handling for optional fields? (maybe generate a HasFoo, you can always ignore if you don't care) @@ -120,6 +120,10 @@ Runtime: - integration tests against common servers for graphql package - send hash rather than full query +Internal: +- set up linting beyond `go vet` +- switch to a snapshot testing lib (cupaloy looks good) for tests + Other: - (+) API cleanup (check godoc) - (+) improved validation and error checking