cancellable SignalClient & tracing

crates/livekit-webrtc/libwebrtc-sys/src/data_channel.rs

@@ -1,3 +1,4 @@
+use std::fmt::{Debug, Formatter};
 use std::slice;
 
 #[cxx::bridge(namespace = "livekit")]

crates/livekit-webrtc/libwebrtc-sys/src/jsep.rs

@@ -83,21 +83,9 @@ impl Display for ffi::SdpParseError {
     }
 }
 
-impl Debug for ffi::SessionDescription {
-    fn fmt(&self, f: &mut Formatter) -> std::fmt::Result {
-        write!(f, "{}", self.stringify())
-    }
-}
-
 unsafe impl Send for ffi::SessionDescription {}
 unsafe impl Sync for ffi::SessionDescription {}
 
-impl Debug for ffi::IceCandidate {
-    fn fmt(&self, f: &mut Formatter) -> std::fmt::Result {
-        write!(f, "{}", self.stringify())
-    }
-}
-
 unsafe impl Send for ffi::IceCandidate {}
 unsafe impl Sync for ffi::IceCandidate {}
 

crates/livekit-webrtc/libwebrtc-sys/src/peer_connection.rs

@@ -1,3 +1,4 @@
+use std::fmt::{Debug, Formatter};
 use cxx::UniquePtr;
 
 use crate::candidate::ffi::Candidate;

crates/livekit-webrtc/libwebrtc-sys/src/rtc_error.rs

@@ -59,8 +59,8 @@ impl ffi::RTCError {
         let message = String::from(&value[22..]); // msg isn't encoded
 
         Self {
-            error_type: unsafe { std::mem::transmute(error_type) },
-            error_detail: unsafe { std::mem::transmute(error_detail) },
+            error_type: std::mem::transmute(error_type),
+            error_detail: std::mem::transmute(error_detail),
             sctp_cause_code,
             has_sctp_cause_code: has_scp_cause_code == 1,
             message,
@@ -68,7 +68,7 @@ impl ffi::RTCError {
     }
 
     pub fn ok(&self) -> bool {
-        return self.error_type == RTCErrorType::None;
+        self.error_type == RTCErrorType::None
     }
 }
 

crates/livekit-webrtc/libwebrtc-sys/src/webrtc.cpp

@@ -8,7 +8,7 @@
 
 namespace livekit {
 RTCRuntime::RTCRuntime() {
-  rtc::LogMessage::LogToDebug(rtc::LS_INFO);
+  //rtc::LogMessage::LogToDebug(rtc::LS_INFO);
   RTC_LOG(LS_INFO) << "RTCRuntime()";
   RTC_CHECK(rtc::InitializeSSL()) << "Failed to InitializeSSL()";