fix unknown signal message logging to not crash

This commit is contained in:
David Zhao
2021-09-28 17:34:58 -07:00
parent 4960459c07
commit 9dd4af5e6c
+18 -9
View File
@@ -71,7 +71,8 @@ class SignalClient {
// Attempt Validation // Attempt Validation
try { try {
final validateResponse = await http.get(validateUri); final validateResponse = await http.get(validateUri);
if (validateResponse.statusCode != 200) throw ConnectException(validateResponse.body); if (validateResponse.statusCode != 200)
throw ConnectException(validateResponse.body);
throw ConnectException(); throw ConnectException();
} catch (error) { } catch (error) {
// Pass it up if it's already a `ConnectError` // Pass it up if it's already a `ConnectError`
@@ -114,15 +115,19 @@ class SignalClient {
_ws?.dispose(); _ws?.dispose();
} }
void sendOffer(rtc.RTCSessionDescription offer) => _sendRequest(lk_rtc.SignalRequest( void sendOffer(rtc.RTCSessionDescription offer) =>
_sendRequest(lk_rtc.SignalRequest(
offer: offer.toSDKType(), offer: offer.toSDKType(),
)); ));
void sendAnswer(rtc.RTCSessionDescription answer) => _sendRequest(lk_rtc.SignalRequest( void sendAnswer(rtc.RTCSessionDescription answer) =>
_sendRequest(lk_rtc.SignalRequest(
answer: answer.toSDKType(), answer: answer.toSDKType(),
)); ));
void sendIceCandidate(rtc.RTCIceCandidate candidate, lk_rtc.SignalTarget target) => _sendRequest( void sendIceCandidate(
rtc.RTCIceCandidate candidate, lk_rtc.SignalTarget target) =>
_sendRequest(
lk_rtc.SignalRequest( lk_rtc.SignalRequest(
trickle: lk_rtc.TrickleRequest( trickle: lk_rtc.TrickleRequest(
candidateInit: candidate.toJson(), candidateInit: candidate.toJson(),
@@ -131,7 +136,8 @@ class SignalClient {
), ),
); );
void sendMuteTrack(String trackSid, bool muted) => _sendRequest(lk_rtc.SignalRequest( void sendMuteTrack(String trackSid, bool muted) =>
_sendRequest(lk_rtc.SignalRequest(
mute: lk_rtc.MuteTrackRequest( mute: lk_rtc.MuteTrackRequest(
sid: trackSid, sid: trackSid,
muted: muted, muted: muted,
@@ -168,7 +174,8 @@ class SignalClient {
subscription: subscription, subscription: subscription,
)); ));
void sendSetSimulcastLayers(String trackSid, List<lk_rtc.VideoQuality> layers) => void sendSetSimulcastLayers(
String trackSid, List<lk_rtc.VideoQuality> layers) =>
_sendRequest(lk_rtc.SignalRequest( _sendRequest(lk_rtc.SignalRequest(
simulcast: lk_rtc.SetSimulcastLayers( simulcast: lk_rtc.SetSimulcastLayers(
trackSid: trackSid, trackSid: trackSid,
@@ -214,7 +221,8 @@ class SignalClient {
)); ));
break; break;
case lk_rtc.SignalResponse_Message.update: case lk_rtc.SignalResponse_Message.update:
events.emit(SignalParticipantUpdateEvent(updates: msg.update.participants)); events.emit(
SignalParticipantUpdateEvent(updates: msg.update.participants));
break; break;
case lk_rtc.SignalResponse_Message.trackPublished: case lk_rtc.SignalResponse_Message.trackPublished:
events.emit(SignalLocalTrackPublishedEvent( events.emit(SignalLocalTrackPublishedEvent(
@@ -223,7 +231,8 @@ class SignalClient {
)); ));
break; break;
case lk_rtc.SignalResponse_Message.speaker: case lk_rtc.SignalResponse_Message.speaker:
events.emit(SignalActiveSpeakersChangedEvent(speakers: msg.speaker.speakers)); events.emit(
SignalActiveSpeakersChangedEvent(speakers: msg.speaker.speakers));
break; break;
case lk_rtc.SignalResponse_Message.leave: case lk_rtc.SignalResponse_Message.leave:
events.emit(SignalLeaveEvent(canReconnect: msg.leave.canReconnect)); events.emit(SignalLeaveEvent(canReconnect: msg.leave.canReconnect));
@@ -235,7 +244,7 @@ class SignalClient {
)); ));
break; break;
default: default:
logger.warning('unsupported message: ' + json.encode(msg)); logger.warning('skipping unsupported signal message');
} }
} }