fix checks

This commit is contained in:
Hiroshi Horie
2022-05-15 23:58:35 +09:00
parent 566937f630
commit 740efea006
4 changed files with 11 additions and 11 deletions
+2 -2
View File
@@ -62,8 +62,8 @@ class Transport extends Disposable {
[RTCConfiguration? rtcConfig]) async { [RTCConfiguration? rtcConfig]) async {
rtcConfig ??= const RTCConfiguration(); rtcConfig ??= const RTCConfiguration();
logger.fine('[PCTransport] creating ${rtcConfig.toMap()}'); logger.fine('[PCTransport] creating ${rtcConfig.toMap()}');
final _ = await peerConnectionCreate(rtcConfig.toMap()); final pc = await peerConnectionCreate(rtcConfig.toMap());
return Transport._(_); return Transport._(pc);
} }
late final negotiate = Utils.createDebounceFunc( late final negotiate = Utils.createDebounceFunc(
+5 -5
View File
@@ -120,17 +120,17 @@ abstract class EventsListenable<T> extends Disposable {
// listens to all events, guaranteed to be cancelled on dispose // listens to all events, guaranteed to be cancelled on dispose
CancelListenFunc listen(FutureOr<void> Function(T) onEvent) { CancelListenFunc listen(FutureOr<void> Function(T) onEvent) {
// //
FutureOr<void> Function(T) _func = onEvent; FutureOr<void> Function(T) func = onEvent;
if (synchronized) { if (synchronized) {
// ensure `onEvent` will trigger one by one (waits for previous `onEvent` to complete) // ensure `onEvent` will trigger one by one (waits for previous `onEvent` to complete)
_func = (event) async { func = (event) async {
await _syncLock.synchronized(() async { await _syncLock.synchronized(() async {
await onEvent(event); await onEvent(event);
}); });
}; };
} }
final listener = emitter.streamCtrl.stream.listen(_func); final listener = emitter.streamCtrl.stream.listen(func);
_listeners.add(listener); _listeners.add(listener);
// make a cancel func to cancel listening and remove from list in 1 call // make a cancel func to cancel listening and remove from list in 1 call
@@ -165,7 +165,7 @@ abstract class EventsListenable<T> extends Disposable {
}) async { }) async {
final completer = Completer<E>(); final completer = Completer<E>();
final _cancelFunc = on<E>( final cancelFunc = on<E>(
(event) { (event) {
if (!completer.isCompleted) { if (!completer.isCompleted) {
completer.complete(event); completer.complete(event);
@@ -183,7 +183,7 @@ abstract class EventsListenable<T> extends Disposable {
// do not catch exceptions and pass it up // do not catch exceptions and pass it up
} finally { } finally {
// always clean-up listener // always clean-up listener
await _cancelFunc.call(); await cancelFunc.call();
} }
} }
} }
+2 -2
View File
@@ -25,8 +25,8 @@ mixin _Disposer {
logger.finer( logger.finer(
'[$objectId] running ${_disposeFuncs.length} dispose funcs...'); '[$objectId] running ${_disposeFuncs.length} dispose funcs...');
// call dispose funcs in reverse order // call dispose funcs in reverse order
for (final _func in _disposeFuncs.reversed) { for (final disposeFunc in _disposeFuncs.reversed) {
await _func(); await disposeFunc();
} }
_disposeFuncs.clear(); _disposeFuncs.clear();
logger.finer('[$objectId] dispose complete.'); logger.finer('[$objectId] dispose complete.');
+2 -2
View File
@@ -30,8 +30,8 @@ class LiveKitWebSocketWeb extends LiveKitWebSocket {
logger.warning('$objectId already disposed, ignoring received data.'); logger.warning('$objectId already disposed, ignoring received data.');
return; return;
} }
dynamic _data = _.data is ByteBuffer ? _.data.asUint8List() : _.data; dynamic data = _.data is ByteBuffer ? _.data.asUint8List() : _.data;
options?.onData?.call(_data); options?.onData?.call(data);
}); });
_closeSubscription = _ws.onClose.listen((_) async { _closeSubscription = _ws.onClose.listen((_) async {
await _messageSubscription.cancel(); await _messageSubscription.cancel();