From 4a75d78ef9164f536ec774184c192a280e7ae241 Mon Sep 17 00:00:00 2001 From: David Zhao Date: Mon, 30 Aug 2021 22:11:29 -0700 Subject: [PATCH] update readmes --- .github/workflows/publish.yaml | 8 -------- README.md | 2 +- example/README.md | 4 +--- example/lib/room.dart | 3 +-- 4 files changed, 3 insertions(+), 14 deletions(-) diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index e1bf8d4..00adbd6 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -2,8 +2,6 @@ name: Publish build on: push: - # test docs - branches: [ main ] # only publish on version tags tags: - v* @@ -13,12 +11,6 @@ jobs: # This job will run on ubuntu virtual machine runs-on: ubuntu-latest steps: - # # Setup Java environment in order to build the Android app. - # - uses: actions/checkout@v1 - # - uses: actions/setup-java@v1 - # with: - # java-version: '12.x' - # Setup the flutter environment. - uses: subosito/flutter-action@v1 diff --git a/README.md b/README.md index 738ec23..4196a81 100644 --- a/README.md +++ b/README.md @@ -58,7 +58,7 @@ We built a multi-user conferencing app as an example in the [example/](example/) ### Connecting to a room, publish video & audio ```dart -var room = await LiveKitClient.connect(this.url, this.token); +var room = await LiveKitClient.connect(url, token); try { // video will fail when running in ios simulator var localVideo = await LocalVideoTrack.createCameraTrack(); diff --git a/example/README.md b/example/README.md index 6885242..4a2d38f 100644 --- a/example/README.md +++ b/example/README.md @@ -1,5 +1,3 @@ # LiveKit Flutter Example -This project creates a video room using LiveKit's Flutter SDK. Designed to run for iOS/Android. (web untested). - -Docs coming soon. +This app implements a video room using LiveKit's Flutter SDK. Designed to run for iOS, Android, and web. diff --git a/example/lib/room.dart b/example/lib/room.dart index d7b9667..ae94ce0 100644 --- a/example/lib/room.dart +++ b/example/lib/room.dart @@ -200,9 +200,8 @@ class _VideoViewState extends State with ParticipantDelegate { !pub.isScreenShare && pub.subscribed; }); - setState(() { - if (subscribedVideos.length > 0) { + if (subscribedVideos.isNotEmpty) { var videoPub = subscribedVideos.first; if (videoPub is RemoteTrackPublication) { videoPub.videoQuality = widget.quality;