V3.0 Update

refactor(board): Update to z3.2

Major update to underlying code requires change to the repo, brought in line with zmk pr for commonality, fixed indentation to comply with zmk pre-commit formatting reqs

Update settings-reset, change RGB modes

Add Update instructions, Assets folder

UPGRADE.md

@@ -0,0 +1,62 @@
+# Advantage 360 Pro ZMK upgrade guide
+
+The last V2.0 update and the new V3.0 branch have introduced changes into the keymap files that causes merge conflicts for people updating with custom keymaps. This guide covers what changed, why it changed and how to fix it.
+
+## What changed and why
+
+To resolve issues some users were encountering with out of matrix keypresses, as well as to streamline the keymap for all future updates, several keys that are unused were removed from the keymap and [matrix transform](https://zmk.dev/docs/config/kscan#matrix-transform). Formatting was also standardised to fall in line with ZMK formatting conventions. As a result the board definition for the Advantage 360 Pro as it stands to get merged into ZMK main [here](https://github.com/zmkfirmware/zmk/pull/1454) matches the one in this repository to the greatest extent possible. 
+These changes result in a merge conflict when two diverging git branches try to get added together in the updating procedure.
+This sort of breaking change shouldn't happen again in the future.
+
+## How to solve the merge conflict
+
+In order to solve the merge conflict all that has to be done is for the conflicting key behaviours to be manually removed from two files.
+- adv360.keymap
+
+![The highlighted &none behaviours that need removing](/assets/keymap.jpg)
+- keymap.json
+
+![The highlighted &none behaviours that need removing](/assets/json.jpg)
+
+These highlighted keys must be removed from each layer in both files. Be careful to preserve a comma in between every key behaviour in the keymap.json and at least one space between every behaviour in adv360.keymap or firmware builds will fail. The quotes need correctly preserving on the behaviours in keymap.json. Each behaviour needs to be wrapped in quotes. Whitespace within the quotes is ignored.
+If you try to update your fork using the GitHub web interface you will see an error saying "This branch has merge conflicts and cannot be merged automatically" and you will be prompted to open a pull request instead. Solving the merge conflict this way is more challenging than doing it on GitHub desktop.
+
+### Github Desktop 
+
+This assumes you already have [GitHub desktop](https://desktop.github.com/) downloaded, installed and you have logged in using the GitHub credentials for your account. Whilst it would be helpful to have an alternative text editor such as VSCode installed this task can be completed with notepad 
+1. Clone your repository
+
+        Navigate in the menu to File->Clone repository. Your fork of the Adv360-Pro-ZMK repository should be visible in the menu of repositories to choose from. Click the blue "Clone" button
+2. Open the folder
+
+    Open the folder by using the "Show in your file manager" option and navigate to the "config" folder
+3. Edit keymap.json
+
+    Open keymap.json, and for each layer remove the 8 highlighted &none behaviours including the quotes wrapping them, and the commas
+4. Edit adv 360.keymap
+
+    Open adv360.keymap and remove the 8 highlighted &none behaviours in each later
+5. Commit your changes
+
+    Returning to GitHub desktop you should see the changes you made in the bar on the left. Type an appropriate commit summary and click "Commit to *branch name*"
+
+    ![The commit dialog of GitHub Desktop](/assets/commit.jpg)
+
+6. Merge
+
+    Navigate to Branch->Merge into current branch and select "upstream/V2.0" or "upstream/V3.0". You will see a warning that there will be two conflicted files. Click "Create a merge commit".
+
+    ![The merge dialog showing a warning of conflicts](/assets/merge.jpg)
+
+7. Resolve Conflicts
+
+    The conflict resolution window has powerful options to soresolve the merge conflict, you will want to clik on the down arrow next to "Open in *your text editor*" and click use the modified file from *your branch name*. In the case of this example it is called V2.0-beta. Using the file from upstream/V2.0 or upstream/V3.0 will result in none of your keymap changes being preserved. 
+    Do this for both files then you will be able to click the "Continue Merge" option
+
+    ![The merge dialog showing a warning of conflicts](/assets/conflict.jpg)
+8. Push
+
+    Once the merge is complete you should be able to click the "push origin" button in the top bar. At this point your changes should be uploaded to GitHub servers and the build should start
+9. Test your firmware
+
+    When the build succeeds download the uf2 files and flash them as normal. Test the keymap, if keys are shifted one way or the other it's likely you deleted too many or not enough behaviours. 

config/boards/arm/adv360/Kconfig.board

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2021 Polarity Works
+# Copyright (c) 2022 The ZMK Contributors
 # SPDX-License-Identifier: MIT
 #
 

config/boards/arm/adv360/Kconfig.defconfig

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2021 Polarity Works
+# Copyright (c) 2022 The ZMK Contributors
 # SPDX-License-Identifier: MIT
 #
 
@@ -8,6 +8,8 @@ if BOARD_ADV360_LEFT
     config ZMK_KEYBOARD_NAME
     default "Adv360 Pro"
 
+    config ZMK_SPLIT_ROLE_CENTRAL
+    default y
 endif # BOARD_ADV360_LEFT
 
 if BOARD_ADV360_RIGHT

config/boards/arm/adv360/adv360.dtsi

@@ -11,20 +11,21 @@
 #include <dt-bindings/led/led.h>
 #include <dt-bindings/zmk/matrix_transform.h>
 
+#include "adv360_pinctrl.dtsi"
+
 / {
     model = "Adv360";
-	compatible = "adv360";
+    compatible = "kinesis,adv360";
 
     chosen {
         zephyr,code-partition = &code_partition;
         zephyr,sram = &sram0;
         zephyr,flash = &flash0;
         zmk,kscan = &kscan0;
-		zmk,underglow = &led_strip;
         zmk,backlight = &backlight;
-		zmk,matrix_transform = &default_transform;
         zmk,battery = &vbatt;
-		zephyr,console = &cdc_acm_uart;
+        zmk,matrix_transform = &default_transform;
+        zmk,underglow = &led_strip;
     };
 
     default_transform: keymap_transform_0 {
@@ -47,35 +48,28 @@
             label = "EXT_POWER";
             control-gpios = <&gpio0 13 GPIO_ACTIVE_HIGH>;
         };
-	backlight: pwmleds {
-    compatible = "pwm-leds";
-    label = "Backlight LEDs";
-    pwm_led_0 {
-        pwms = <&pwm0 17>;
-        label = "Backlight LED 0";
-    };
-
-};
-	leds {
-		compatible = "gpio-leds";
-		blue_led: led_0 {
-			gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
-			label = "Blue LED";
-		};
-	};
 
     vbatt: vbatt {
         compatible = "zmk,battery-voltage-divider";
-		label = "VBATT";
         io-channels = <&adc 2>;
         output-ohms = <100000>;
         full-ohms = <(100000 + 100000)>;
     };
+
+    backlight: pwmleds {
+            compatible = "pwm-leds";
+            pwm_led_0 {
+                pwms = <&pwm0 0 10000 PWM_POLARITY_NORMAL>;
+            };
+        };
+
 };
 
 &pwm0 {
     status = "okay";
-	ch0-pin = <17>;
+    pinctrl-0 = <&pwm0_default>;
+    pinctrl-1 = <&pwm0_sleep>;
+    pinctrl-names = "default", "sleep";
 };
 
 &adc {
@@ -95,21 +89,7 @@
 };
 
 &usbd {
-	status = "disabled";
-	cdc_acm_uart: cdc_acm_uart {
-    compatible = "zephyr,cdc-acm-uart";
-    label = "CDC_ACM_0";
-  };
-};
-
-&uart0 {
-	compatible = "nordic,nrf-uarte";
     status = "okay";
-	current-speed = <115200>;
-	tx-pin = <39>;
-	rx-pin = <44>;
-	rts-pin = <34>;
-	cts-pin = <9>;
 };
 
 
@@ -153,13 +133,12 @@
     };
 };
 
-&spi1 {
+&spi3 {
     compatible = "nordic,nrf-spim";
     status = "okay";
-	mosi-pin = <20>;
+    pinctrl-0 = <&spi3_default>;
-	// Unused pins, needed for SPI definition, but not used by the ws2812 driver itself.
+    pinctrl-1 = <&spi3_sleep>;
-	sck-pin = <27>;
+    pinctrl-names = "default", "sleep";
-	miso-pin = <8>;
 
     led_strip: ws2812@0 {
         compatible = "worldsemi,ws2812-spi";

config/boards/arm/adv360/adv360.yaml

@@ -1,5 +1,5 @@
 identifier: adv360
-name: Adv360
+name: Advantage 360 Pro
 type: keyboard
 arch: arm
 toolchain:

config/boards/arm/adv360/adv360.zmk.yml

@@ -0,0 +1,16 @@
+file_format: "1"
+id: adv360
+name: Advantage 360 Pro
+type: board
+url: https://kinesis-ergo.com/keyboards/advantage360
+arch: arm
+features:
+  - keys
+  - underglow
+  - backlight
+outputs:
+  - usb
+  - ble
+siblings:
+  - adv360pro_left
+  - adv360pro_right

config/boards/arm/adv360/adv360_left.dts

@@ -10,7 +10,6 @@
 /{
     kscan0: kscan {
         compatible = "zmk,kscan-gpio-matrix";
-		label = "KSCAN";
 
         diode-direction = "col2row";
         row-gpios
@@ -34,13 +33,4 @@
             , <&gpio0 7 GPIO_ACTIVE_HIGH>
             ;
     };
-
-	leds {
-		compatible = "gpio-leds";
-		blue_led: led_0 {
-			gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
-			label = "Blue LED";
-		};
-	};
-
 };

config/boards/arm/adv360/adv360_left_defconfig

@@ -1,15 +1,11 @@
 #
-# Copyright (c) 2021 Polarity Works
+# Copyright (c) 2022 The ZMK Contributors
 # SPDX-License-Identifier: MIT
 #
 
 CONFIG_SOC_SERIES_NRF52X=y
 CONFIG_SOC_NRF52840_QIAA=y
 CONFIG_BOARD_ADV360_LEFT=y
-CONFIG_ZMK_BLE=y
-
-CONFIG_ZMK_SPLIT=y
-CONFIG_ZMK_SPLIT_ROLE_CENTRAL=y
 
 # Enable MPU
 CONFIG_ARM_MPU=y
@@ -17,10 +13,9 @@ CONFIG_ARM_MPU=y
 # enable GPIO
 CONFIG_GPIO=y
 
-
+# Enable SPI for LEDS
-# Enable SPI
+CONFIG_PINCTRL=y
 CONFIG_SPI=y
-
 CONFIG_SPI_NRFX=y
 
 # Enable writing to flash
@@ -34,28 +29,37 @@ CONFIG_FLASH_MAP=y
 
 # Enable 32kHz crystal
 CONFIG_CLOCK_CONTROL_NRF_K32SRC_XTAL=y
-CONFIG_CLOCK_CONTROL_NRF_K32SRC_500PPM=y
+CONFIG_CLOCK_CONTROL_NRF_K32SRC_150PPM=y
 
+#RGB leds config
+CONFIG_WS2812_STRIP=y
 CONFIG_ZMK_RGB_UNDERGLOW=y
 CONFIG_ZMK_RGB_UNDERGLOW_EXT_POWER=y
 CONFIG_ZMK_RGB_UNDERGLOW_ON_START=y
 CONFIG_ZMK_RGB_UNDERGLOW_EFF_START=4
 CONFIG_ZMK_RGB_UNDERGLOW_AUTO_OFF_IDLE=y
 
-# Use the STRIP config specific to the LEDs you're using
+#Backlighting configuration
-CONFIG_WS2812_STRIP=y
-CONFIG_BT_CTLR_TX_PWR_PLUS_8=y
 CONFIG_PWM=y
 CONFIG_LED_PWM=y
 CONFIG_ZMK_BACKLIGHT=y
+CONFIG_ZMK_BACKLIGHT_BRT_START=20
 CONFIG_ZMK_BACKLIGHT_AUTO_OFF_IDLE=y
 
-CONFIG_ZMK_HID_REPORT_TYPE_NKRO=y
+#BT configuration
-CONFIG_ZMK_HID_CONSUMER_REPORT_USAGES_BASIC=y
+CONFIG_BT_CTLR_TX_PWR_PLUS_8=y
+CONFIG_BT_DIS_MANUF="Kinesis Corporation"
+CONFIG_BT_PRIVACY=y
+CONFIG_BT_GAP_PERIPHERAL_PREF_PARAMS=y
+CONFIG_BT_PERIPHERAL_PREF_TIMEOUT=600
+CONFIG_BT_PERIPHERAL_PREF_MIN_INT=12
+CONFIG_BT_PERIPHERAL_PREF_MAX_INT=24
+CONFIG_BT_PERIPHERAL_PREF_LATENCY=30
 
+#Misc configuration
 CONFIG_USB_DEVICE_VID=0x29EA
 CONFIG_USB_DEVICE_PID=0x0362
 CONFIG_USB_DEVICE_MANUFACTURER="Kinesis Corporation"
-CONFIG_BT_DIS_MANUF="Kinesis Corporation"
+CONFIG_ZMK_HID_REPORT_TYPE_NKRO=y
-
+CONFIG_ZMK_HID_CONSUMER_REPORT_USAGES_BASIC=y
 CONFIG_BUILD_OUTPUT_UF2=y

config/boards/arm/adv360/adv360_pinctrl.dtsi

@@ -0,0 +1,30 @@
+/*
+ * Copyright (c) 2023 The ZMK Contributors
+ * SPDX-License-Identifier: MIT
+ */
+
+&pinctrl {
+    spi3_default: spi3_default {
+        group1 {
+            psels = <NRF_PSEL(SPIM_MOSI, 0, 20)>;
+        };
+    };
+
+    spi3_sleep: spi3_sleep {
+        group1 {
+            psels = <NRF_PSEL(SPIM_MOSI, 0, 20)>;
+            low-power-enable;
+        };
+    };
+    pwm0_default: pwm0_default {
+        group1 {
+            psels = <NRF_PSEL(PWM_OUT0, 0, 17)>;
+        };
+    };
+    pwm0_sleep: pwm0_sleep {
+        group1 {
+            psels = <NRF_PSEL(PWM_OUT0, 0, 17)>;
+            low-power-enable;
+        };
+    };
+};

config/boards/arm/adv360/adv360_right.dts

@@ -13,7 +13,6 @@
 
     kscan0: kscan {
         compatible = "zmk,kscan-gpio-matrix";
-		label = "KSCAN";
 
         diode-direction = "col2row";
         row-gpios
@@ -37,15 +36,6 @@
             , <&gpio0 28 GPIO_ACTIVE_HIGH>
             ;
     };
-
-	leds {
-			compatible = "gpio-leds";
-			blue_led: led_0 {
-				gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
-				label = "Blue LED";
-			};
-		};
-
 };
 
 &default_transform {

config/boards/arm/adv360/adv360_right_defconfig

@@ -1,14 +1,11 @@
 #
-# Copyright (c) 2021 Polarity Works
+# Copyright (c) 2022 The ZMK Contributors
 # SPDX-License-Identifier: MIT
 #
 
 CONFIG_SOC_SERIES_NRF52X=y
 CONFIG_SOC_NRF52840_QIAA=y
 CONFIG_BOARD_ADV360_RIGHT=y
-CONFIG_ZMK_BLE=y
-CONFIG_ZMK_SPLIT=y
-
 
 # Enable MPU
 CONFIG_ARM_MPU=y
@@ -16,9 +13,8 @@ CONFIG_ARM_MPU=y
 # enable GPIO
 CONFIG_GPIO=y
 
-
+# Enable SPI for LEDS
-
+CONFIG_PINCTRL=y
-# Enable SPI
 CONFIG_SPI=y
 CONFIG_SPI_NRFX=y
 
@@ -33,27 +29,28 @@ CONFIG_FLASH_MAP=y
 
 # Enable 32kHz crystal
 CONFIG_CLOCK_CONTROL_NRF_K32SRC_XTAL=y
-CONFIG_CLOCK_CONTROL_NRF_K32SRC_500PPM=y
+CONFIG_CLOCK_CONTROL_NRF_K32SRC_150PPM=y
 
+#RGB leds config
+CONFIG_WS2812_STRIP=y
 CONFIG_ZMK_RGB_UNDERGLOW=y
 CONFIG_ZMK_RGB_UNDERGLOW_EXT_POWER=y
 CONFIG_ZMK_RGB_UNDERGLOW_ON_START=y
 CONFIG_ZMK_RGB_UNDERGLOW_EFF_START=4
 CONFIG_ZMK_RGB_UNDERGLOW_AUTO_OFF_IDLE=y
 
-# Use the STRIP config specific to the LEDs you're using
+#Backlighting configuration
-CONFIG_WS2812_STRIP=y
-CONFIG_BT_CTLR_TX_PWR_PLUS_8=y
 CONFIG_PWM=y
 CONFIG_LED_PWM=y
 CONFIG_ZMK_BACKLIGHT=y
+CONFIG_ZMK_BACKLIGHT_BRT_START=20
 CONFIG_ZMK_BACKLIGHT_AUTO_OFF_IDLE=y
 
-CONFIG_ZMK_HID_REPORT_TYPE_NKRO=y
+#Misc configuration
-CONFIG_ZMK_HID_CONSUMER_REPORT_USAGES_BASIC=y
-
 CONFIG_USB_DEVICE_VID=0x29EA
 CONFIG_USB_DEVICE_PID=0x0362
 CONFIG_USB_DEVICE_MANUFACTURER="Kinesis Corporation"
-
+CONFIG_BT_CTLR_TX_PWR_PLUS_8=y
+CONFIG_ZMK_HID_REPORT_TYPE_NKRO=y
+CONFIG_ZMK_HID_CONSUMER_REPORT_USAGES_BASIC=y
 CONFIG_BUILD_OUTPUT_UF2=y

config/boards/arm/adv360/board.cmake

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2021 Polarity Works
+# Copyright (c) 2022 The ZMK Contributors
 # SPDX-License-Identifier: MIT
 #
 

config/boards/arm/adv360/macros.dtsi

@@ -0,0 +1,36 @@
+  macro_quotes: macro_quotes {
+    compatible = "zmk,behavior-macro";
+    label = "macro_quotes";
+    #binding-cells = <0>;
+    bindings = <&kp SQT>, <&kp SQT>, <&kp LEFT>;
+  };
+  macro_dquotes: macro_dquotes {
+    compatible = "zmk,behavior-macro";
+    label = "macro_dquotes";
+    #binding-cells = <0>;
+    bindings = <&kp DQT>, <&kp DQT>, <&kp LEFT>;
+  };
+  macro_braces: macro_braces {
+    compatible = "zmk,behavior-macro";
+    label = "macro_braces";
+    #binding-cells = <0>;
+    bindings = <&kp LBRC>, <&kp RBRC>, <&kp LEFT>;
+  };
+  macro_parens: macro_parens {
+    compatible = "zmk,behavior-macro";
+    label = "macro_parens";
+    #binding-cells = <0>;
+    bindings = <&kp LPAR>, <&kp RPAR>, <&kp LEFT>;
+  };
+  macro_brackets: macro_brackets {
+    compatible = "zmk,behavior-macro";
+    label = "macro_brackets";
+    #binding-cells = <0>;
+    bindings = <&kp LBKT>, <&kp RBKT>, <&kp LEFT>;
+  };
+  macro_kinesis: macro_kinesis {
+    compatible = "zmk,behavior-macro";
+    label = "macro_kinesis";
+    #binding-cells = <0>;
+    bindings = <&kp K>, <&kp I>, <&kp N>, <&kp E>, <&kp S>, <&kp I>, <&kp S>;
+  };

config/keymap.json

@@ -30,9 +30,9 @@
     ], [
       "&none ", "&bt BT_SEL 0 ", "&bt BT_SEL 1 ", "&bt BT_SEL 2 ", "&bt BT_SEL 3 ", "&bt BT_SEL 4 ", "&none                                                                                        ", "&trans        ", "&none        ", "&none        ", "&none        ", "&none        ", "&none        ", "&none",
       "&none ", "&none        ", "&none        ", "&none        ", "&none        ", "&none        ", "&bootloader                                                                                  ", "&bootloader   ", "&none        ", "&none        ", "&none        ", "&none        ", "&none        ", "&none",
-      "&none ", "&none        ", "&none        ", "&none        ", "&none        ", "&none        ", "&rgb_ug RGB_MEFS_CMD 5     ", "&none",       "&bt BT_CLR ", "&bt BT_CLR ", "&bt BT_CLR       ", "&rgb_ug RGB_MEFS_CMD 5 ", "&none        ", "&none        ", "&none        ", "&none        ", "&none        ", "&none",
+      "&none ", "&none        ", "&none        ", "&none        ", "&none        ", "&none        ", "&none                ", "&none", "&none ", "&bt BT_CLR ", "&none ",                             "&rgb_ug RGB_MEFS_CMD 5 ", "&none        ", "&none        ", "&none        ", "&none        ", "&none        ", "&none",
-      "&none ", "&none        ", "&none        ", "&none        ", "&none        ", "&none                   ", "&none           ", "&none      ", "&none ",      "&none      ",                                        "&none        ", "&none        ", "&none        ", "&none        ", "&none        ", "&none",
+      "&none ", "&none        ", "&none        ", "&none        ", "&none        ", "&none                                          ", "&none ", "&none ",                                                              "&none        ", "&none        ", "&none        ", "&none        ", "&none        ", "&none",
-      "&none ", "&none        ", "&none        ", "&bl BL_INC   ", "&bl BL_DEC                               ", "&none           ", "&bl BL_TOG ", "&none ",      "&none      ", "&bl BL_TOG ", "&rgb_ug RGB_TOG                                ", "&bl BL_INC   ", "&bl BL_DEC   ", "&none        ", "&none        ", "&none"
+      "&none ", "&none        ", "&none        ", "&none        ", "&none                                         ", "&none", "&none", "&none ", "&none      ", "&bl BL_TOG ", "&rgb_ug RGB_TOG                                ", "&bl BL_INC   ", "&bl BL_DEC   ", "&none        ", "&none        ", "&none"
     ]
   ]
 }

config/west.yml

@@ -7,7 +7,7 @@ manifest:
   projects:
     - name: zmk
       remote: refil
-      revision: adv360-z3
+      revision: adv360-z3.2
       import: app/west.yml
   self:
     path: config