FlowyLabs/llink
1
0
Fork 0
Code Issues 71 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: avatars for humans #273

Merged
talksik merged 11 commits from worktree-refactored-strolling-treasure into main 2026-06-11 22:30:21 +00:00
Conversation 3 Commits 11 Files Changed 25
+1 -1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a25fb83a2a - Show all commits
go/migrations/000017_human_avatar.down.sql
+1 -1
View File
@@ -1,6 +1,6 @@
BEGIN;
coderabbitai[bot] commented 2026-06-11 22:11:53 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Fix invalid SQL in rollback migration.

Line 4 has a trailing comma, which makes the down migration fail to execute.

Suggested fix 
 ALTER TABLE humans
-  DROP COLUMN IF EXISTS avatar_object_id,
+  DROP COLUMN IF EXISTS avatar_object_id;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

ALTER TABLE humans
  DROP COLUMN IF EXISTS avatar_object_id;
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go/migrations/000017_human_avatar.down.sql` at line 4, The rollback migration
SQL in 000017_human_avatar.down.sql contains a trailing comma after the DROP
COLUMN list ("DROP COLUMN IF EXISTS avatar_object_id,") which makes the
statement invalid; remove the trailing comma so the DROP COLUMN clause is a
properly terminated SQL statement (ensure the DROP COLUMN list ends without a
comma and the statement ends with the appropriate semicolon or end-of-statement
token).

✅ Addressed in commits a45beb9 to a25fb83

_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_ **Fix invalid SQL in rollback migration.** Line 4 has a trailing comma, which makes the down migration fail to execute. <details> <summary>Suggested fix</summary> ```diff ALTER TABLE humans - DROP COLUMN IF EXISTS avatar_object_id, + DROP COLUMN IF EXISTS avatar_object_id; ``` </details> <!-- suggestion_start --> <details> <summary>📝 Committable suggestion</summary> > ‼️ **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. ```suggestion ALTER TABLE humans DROP COLUMN IF EXISTS avatar_object_id; ``` </details> <!-- suggestion_end --> <details> <summary>🤖 Prompt for AI Agents</summary> ``` Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go/migrations/000017_human_avatar.down.sql` at line 4, The rollback migration SQL in 000017_human_avatar.down.sql contains a trailing comma after the DROP COLUMN list ("DROP COLUMN IF EXISTS avatar_object_id,") which makes the statement invalid; remove the trailing comma so the DROP COLUMN clause is a properly terminated SQL statement (ensure the DROP COLUMN list ends without a comma and the statement ends with the appropriate semicolon or end-of-statement token). ``` </details> <!-- fingerprinting:phantom:poseidon:hawk --> <!-- cr-comment:v1:6d0227aabf7772fa5ddadda5 --> <!-- This is an auto-generated comment by CodeRabbit --> ✅ Addressed in commits a45beb9 to a25fb83
ALTER TABLE humans
DROP COLUMN IF EXISTS avatar_object_id,
DROP COLUMN IF EXISTS avatar_object_id;
COMMIT;