fix: remove enforced recording limit #297

2026-06-21T15:30:41Z

talksik commented

2026-06-21 15:30:41 +00:00

(Migrated from github.com)

Summary by CodeRabbit

Bug Fixes
- Recording behavior updated: instead of automatically stopping at the maximum duration limit, a warning message now displays when the limit is reached.

## Summary by CodeRabbit * **Bug Fixes** * Recording behavior updated: instead of automatically stopping at the maximum duration limit, a warning message now displays when the limit is reached.

coderabbitai[bot] commented

2026-06-21 15:30:49 +00:00

(Migrated from github.com)

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: 74a061bb-40c5-485a-b5d9-5869c2fd4711

📥 Commits

Reviewing files that changed from the base of the PR and between bfe53b46cf and 2963098e4b.

📒 Files selected for processing (2)

js/desktop/src/features/compose/recording-overlay.tsx
js/desktop/src/lib/constants.ts

📝 Walkthrough

Walkthrough

useRecordingCountdown is refactored to remove the auto-stop dispatch that fired when the recording duration cap was reached. The hook now only updates elapsed on a 1-second interval and, at the cap, sets isWarning and emits a one-time toast.warning. The RECORDING_WARNING_SECONDS constant is deleted from constants.ts.

Changes

Recording Cap Behavior

Layer / File(s)	Summary
Recording cap: remove auto-stop, add warning toast `js/desktop/src/lib/constants.ts`, `js/desktop/src/features/compose/recording-overlay.tsx`	Removes `RECORDING_WARNING_SECONDS` from constants, drops the `requestIntent` auto-stop dispatch and warning threshold from `useRecordingCountdown`, and replaces cap-reached behavior with 1-second polling that sets `isWarning` and fires a one-time `toast.warning` from `sonner`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Tick, tick, tick goes the clock on the wall,
No more stopping the stream when I reach the hall!
A toast pops up bright with a warning so fair,
isWarning is set, and the timer's still there.
No requestIntent, no threshold to seek —
Just a bunny who hops til the timer goes squeak! 🎙️

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/flowy-live/llink/pull/297?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)  <details> <summary>ℹ️ Recent review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Free **Run ID**: `74a061bb-40c5-485a-b5d9-5869c2fd4711` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between bfe53b46cf5f113e232e71bfa92ec657632714ce and 2963098e4becad62e1325dd5bde323baf3124e04. </details> <details> <summary>📒 Files selected for processing (2)</summary> * `js/desktop/src/features/compose/recording-overlay.tsx` * `js/desktop/src/lib/constants.ts` </details> </details> ---  <details> <summary>📝 Walkthrough</summary> ## Walkthrough `useRecordingCountdown` is refactored to remove the auto-stop dispatch that fired when the recording duration cap was reached. The hook now only updates `elapsed` on a 1-second interval and, at the cap, sets `isWarning` and emits a one-time `toast.warning`. The `RECORDING_WARNING_SECONDS` constant is deleted from `constants.ts`. ## Changes **Recording Cap Behavior** | Layer / File(s) | Summary | |---|---| | **Recording cap: remove auto-stop, add warning toast** <br> `js/desktop/src/lib/constants.ts`, `js/desktop/src/features/compose/recording-overlay.tsx` | Removes `RECORDING_WARNING_SECONDS` from constants, drops the `requestIntent` auto-stop dispatch and warning threshold from `useRecordingCountdown`, and replaces cap-reached behavior with 1-second polling that sets `isWarning` and fires a one-time `toast.warning` from `sonner`. | ## Estimated code review effort 🎯 2 (Simple) | ⏱️ ~10 minutes ## Poem > 🐰 Tick, tick, tick goes the clock on the wall, > No more stopping the stream when I reach the hall! > A toast pops up bright with a warning so fair, > `isWarning` is set, and the timer's still there. > No `requestIntent`, no threshold to seek — > Just a bunny who hops til the timer goes *squeak*! 🎙️ </details>   --- > [!NOTE] > <details> > <summary>🎁 Summarized by CodeRabbit Free</summary> > > Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting <https://app.coderabbit.ai/login>. > > </details> <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FlowyLabs/llink#297