refactor(errors): route silent catches through logError/reportError

Every catch now either surfaces, re-throws, or calls logError with a scope
tag. No more empty catches or bare console.error:

- auth-store: signInToFirebase / restoreSession / signOut paths gain
  logError context. Behavior is unchanged (best-effort local sign-out,
  fall back to login on restore failure).
- use-stream-autoplay: Audio.play() and download-URL fetches log their
  failures instead of dropping silently (both are nice-to-haves so UX
  stays silent — but we can now trace "why didn't autoplay trigger?").
- pusher-client: ws errors / parse failures / server errors / listener
  crashes all routed through logError, and listener bugs (which silently
  break user flows) now go through reportError so they're actually
  surfaced in observability.
- settings-page: email-notifications toggle now toasts on failure
  instead of silently reverting with no explanation.
- huddle-app: screen-share failures use logError.
This commit is contained in:
Claude
2026-04-17 02:55:23 +00:00
parent 8632c98725
commit 795bdfc286
5 changed files with 40 additions and 20 deletions
+5 -2
View File
@@ -11,6 +11,8 @@ import { ScrollArea } from "@/components/ui/scroll-area";
import { CopyableEmail } from "@/components/copyable-email";
import { useAuthStore } from "@/stores/auth-store";
import { apiClient } from "@/api/client";
import { logError, toUserMessage } from "@/lib/errors";
import { toast } from "sonner";
import { PRIVACY_URL, SUPPORT_EMAIL, TERMS_URL } from "@/lib/constants";
import { ArrowLeft } from "lucide-react";
@@ -84,12 +86,13 @@ export default function SettingsPage() {
}));
try {
await apiClient.updateSettings({ email_notifications_enabled: checked });
} catch {
// Revert on failure
} catch (err) {
setEmailNotifications(!checked);
useAuthStore.setState((state) => ({
user: state.user ? { ...state.user, email_notifications_enabled: !checked } : null,
}));
toast.error(toUserMessage(err));
logError(err, { scope: "settings.emailNotifications" });
}
};