FlowyLabs/llink
1
0
Fork 0
Code Issues 71 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor: improve auth dialog implementation

Browse Source
This commit is contained in:
talksik
2026-01-27 11:55:51 -08:00
parent 88b10a4380
commit 707e4455ac
3 changed files with 212 additions and 206 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/authdialog.cpp
+71 -100
View File
@@ -1,118 +1,89 @@
#include "authdialog.h" #include "authdialog.h"
#include "ui_authdialog.h"
#include "authmanager.h" #include "authmanager.h"
AuthDialog::AuthDialog(AuthManager *authManager, QWidget *parent) AuthDialog::AuthDialog(AuthManager *authManager, QWidget *parent)
: QDialog{parent}, m_authManager(authManager), m_state(ENTER_EMAIL) : QDialog{parent}, m_authManager(authManager), ui(new Ui::Dialog)
{ {
ui = new Ui::Dialog;
ui->setupUi(this); ui->setupUi(this);
// initialize form based on current state // Connect button signals
updateForm(); connect(ui->sendCodeButton, &QPushButton::clicked, this, &AuthDialog::onSendCodeClicked);
connect(ui->signInButton, &QPushButton::clicked, this, &AuthDialog::onSignInClicked);
connect(ui->goBackButton, &QPushButton::clicked, this, [this]() { showEmailPage(); });
connect(ui->sendCodeButton, &QPushButton::clicked, this, [this]() { // Connect AuthManager signals
QString emailInput = ui->emailLineEdit->text(); connect(m_authManager, &AuthManager::codeSentToEmail, this, [this](const QString &) {
if (emailInput.isEmpty()) showCodePage();
{
ui->errorMessage->setText("Must provide a valid email");
return;
}
ui->errorMessage->setText("");
m_authManager->requestSignInCode(emailInput);
}); });
connect(ui->signInButton, &QPushButton::clicked, this, [this]() {
QString codeInput = ui->codeLineEdit->text();
if (codeInput.isEmpty())
{
ui->errorMessage->setText("Must provide a valid code");
return;
}
ui->errorMessage->setText("");
m_authManager->signIn(codeInput);
});
connect(m_authManager, &AuthManager::codeSentToEmail, this, [this](const QString &email) {
m_state = ENTER_CODE;
updateForm();
});
connect(m_authManager, &AuthManager::isSignedInChanged, this, [this]() {
if (m_authManager->isSignedIn())
{
m_state = SIGNED_IN;
}
else
{
m_state = ENTER_EMAIL;
}
updateForm();
});
connect(m_authManager, &AuthManager::errorOccurred, this, [this](const QString &message) { connect(m_authManager, &AuthManager::errorOccurred, this, [this](const QString &message) {
ui->errorMessage->setText(message); setError(message);
ui->errorMessage->show();
}); });
}
void AuthDialog::reset() // Start on email page
{ showEmailPage();
m_state = ENTER_EMAIL;
ui->emailLineEdit->clear();
ui->codeLineEdit->clear();
updateForm();
}
void AuthDialog::updateForm()
{
ui->errorMessage->setText("");
switch (m_state)
{
case ENTER_EMAIL:
ui->successLabel->hide();
ui->sendCodeButton->show();
ui->emailLineEdit->show();
ui->emailLabel->show();
ui->signInButton->hide();
ui->codeLabel->hide();
ui->codeLineEdit->hide();
break;
case ENTER_CODE:
ui->successLabel->hide();
ui->sendCodeButton->hide();
ui->emailLineEdit->hide();
ui->emailLabel->hide();
ui->signInButton->show();
ui->codeLabel->show();
ui->codeLineEdit->show();
break;
case SIGNED_IN:
ui->successLabel->show();
ui->sendCodeButton->hide();
ui->emailLineEdit->hide();
ui->emailLabel->hide();
ui->signInButton->hide();
ui->codeLabel->hide();
ui->codeLineEdit->hide();
break;
default:
break;
}
} }
AuthDialog::~AuthDialog() AuthDialog::~AuthDialog()
{ {
delete ui; delete ui;
} }
void AuthDialog::reset()
{
ui->emailLineEdit->clear();
ui->codeLineEdit->clear();
showEmailPage();
}
void AuthDialog::showEmailPage()
{
ui->stackedWidget->setCurrentIndex(0);
ui->emailLineEdit->setFocus();
setError("");
}
void AuthDialog::showCodePage()
{
ui->stackedWidget->setCurrentIndex(1);
ui->codeLineEdit->setFocus();
setError("");
}
void AuthDialog::setError(const QString &message)
{
// Update error labels on both pages
ui->errorMessage->setText(message);
ui->codeErrorMessage->setText(message);
// Show/hide based on whether there's an error
bool hasError = !message.isEmpty();
ui->errorMessage->setVisible(hasError);
ui->codeErrorMessage->setVisible(hasError);
}
void AuthDialog::onSendCodeClicked()
{
QString email = ui->emailLineEdit->text().trimmed();
if (email.isEmpty())
{
setError("Please enter your email");
return;
}
setError("");
m_authManager->requestSignInCode(email);
}
void AuthDialog::onSignInClicked()
{
QString code = ui->codeLineEdit->text().trimmed();
if (code.isEmpty())
{
setError("Please enter the code");
return;
}
setError("");
m_authManager->signIn(code);
}
src/authdialog.h
+12 -15
View File
@@ -1,37 +1,34 @@
#ifndef AUTHDIALOG_H #ifndef AUTHDIALOG_H
#define AUTHDIALOG_H #define AUTHDIALOG_H
#include <QObject> #include <QDialog>
#include <QWidget>
#include "ui_authdialog.h"
class AuthManager; class AuthManager;
namespace Ui {
class Dialog;
}
class AuthDialog : public QDialog class AuthDialog : public QDialog
{ {
Q_OBJECT Q_OBJECT
public: public:
explicit AuthDialog(AuthManager *, QWidget *parent = nullptr); explicit AuthDialog(AuthManager *authManager, QWidget *parent = nullptr);
~AuthDialog(); ~AuthDialog();
enum State
{
ENTER_EMAIL,
ENTER_CODE,
SIGNED_IN
};
void reset(); void reset();
signals: private slots:
void onSendCodeClicked();
void onSignInClicked();
private: private:
Ui::Dialog *ui; Ui::Dialog *ui;
AuthManager *m_authManager; AuthManager *m_authManager;
State m_state;
void updateForm(); void showEmailPage();
void showCodePage();
void setError(const QString &message);
}; };
#endif // AUTHDIALOG_H #endif // AUTHDIALOG_H
src/authdialog.ui
+129 -91
View File
@@ -13,102 +13,140 @@
<property name="windowTitle"> <property name="windowTitle">
<string>Dialog</string> <string>Dialog</string>
</property> </property>
<widget class="QGroupBox" name="groupBox"> <widget class="QStackedWidget" name="stackedWidget">
<property name="geometry"> <property name="geometry">
<rect> <rect>
<x>80</x> <x>40</x>
<y>30</y> <y>20</y>
<width>231</width> <width>321</width>
<height>183</height> <height>241</height>
</rect> </rect>
</property> </property>
<property name="title"> <property name="currentIndex">
<string>Sign in</string> <number>0</number>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
<widget class="QLabel" name="emailLabel">
<property name="text">
<string>Email</string>
</property>
</widget>
</item>
<item>
<widget class="QLineEdit" name="emailLineEdit">
<property name="sizePolicy">
<sizepolicy hsizetype="Preferred" vsizetype="Fixed">
<horstretch>0</horstretch>
<verstretch>0</verstretch>
</sizepolicy>
</property>
<property name="cursor">
<cursorShape>IBeamCursor</cursorShape>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="codeLabel">
<property name="text">
<string>Code</string>
</property>
</widget>
</item>
<item>
<widget class="QLineEdit" name="codeLineEdit"/>
</item>
<item>
<widget class="QLabel" name="errorMessage">
<property name="text">
<string>Error</string>
</property>
</widget>
</item>
</layout>
</widget>
<widget class="QPushButton" name="sendCodeButton">
<property name="geometry">
<rect>
<x>230</x>
<y>250</y>
<width>101</width>
<height>32</height>
</rect>
</property>
<property name="text">
<string>Send code</string>
</property>
<property name="default">
<bool>true</bool>
</property>
</widget>
<widget class="QPushButton" name="signInButton">
<property name="geometry">
<rect>
<x>230</x>
<y>250</y>
<width>101</width>
<height>32</height>
</rect>
</property>
<property name="text">
<string>Sign in</string>
</property>
<property name="default">
<bool>true</bool>
</property>
</widget>
<widget class="QLabel" name="successLabel">
<property name="geometry">
<rect>
<x>120</x>
<y>120</y>
<width>121</width>
<height>16</height>
</rect>
</property>
<property name="text">
<string>Successful</string>
</property> </property>
<widget class="QWidget" name="enterEmailPage">
<widget class="QGroupBox" name="groupBox">
<property name="geometry">
<rect>
<x>50</x>
<y>20</y>
<width>231</width>
<height>183</height>
</rect>
</property>
<property name="title">
<string>Sign in</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
<widget class="QLabel" name="emailLabel">
<property name="text">
<string>Email</string>
</property>
</widget>
</item>
<item>
<widget class="QLineEdit" name="emailLineEdit">
<property name="sizePolicy">
<sizepolicy hsizetype="Preferred" vsizetype="Fixed">
<horstretch>0</horstretch>
<verstretch>0</verstretch>
</sizepolicy>
</property>
<property name="cursor">
<cursorShape>IBeamCursor</cursorShape>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="errorMessage">
<property name="text">
<string>Error</string>
</property>
</widget>
</item>
<item>
<widget class="QPushButton" name="sendCodeButton">
<property name="text">
<string>Send code</string>
</property>
<property name="default">
<bool>true</bool>
</property>
</widget>
</item>
</layout>
</widget>
</widget>
<widget class="QWidget" name="enterCodePage">
<widget class="QGroupBox" name="groupBox_2">
<property name="geometry">
<rect>
<x>50</x>
<y>20</y>
<width>231</width>
<height>201</height>
</rect>
</property>
<property name="title">
<string>Verify code</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout_2">
<item>
<widget class="QLabel" name="codeLabel">
<property name="text">
<string>Enter the code we sent to your email</string>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QLineEdit" name="codeLineEdit">
<property name="sizePolicy">
<sizepolicy hsizetype="Preferred" vsizetype="Fixed">
<horstretch>0</horstretch>
<verstretch>0</verstretch>
</sizepolicy>
</property>
<property name="cursor">
<cursorShape>IBeamCursor</cursorShape>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="codeErrorMessage">
<property name="text">
<string>Error</string>
</property>
</widget>
</item>
<item>
<layout class="QHBoxLayout" name="horizontalLayout">
<item>
<widget class="QPushButton" name="goBackButton">
<property name="text">
<string>Cancel</string>
</property>
</widget>
</item>
<item>
<widget class="QPushButton" name="signInButton">
<property name="text">
<string>Sign In</string>
</property>
<property name="default">
<bool>true</bool>
</property>
</widget>
</item>
</layout>
</item>
</layout>
</widget>
</widget>
</widget> </widget>
</widget> </widget>
<resources/> <resources/>