From 3a7b896f3ac834606c0960e54b4ded45c243daad Mon Sep 17 00:00:00 2001 From: Arjun Patel Date: Tue, 9 Jun 2026 07:58:57 -0700 Subject: [PATCH] prevent sending email when no recipients --- go/internal/network/service.go | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/go/internal/network/service.go b/go/internal/network/service.go index a39efcf..861d29a 100644 --- a/go/internal/network/service.go +++ b/go/internal/network/service.go @@ -284,18 +284,20 @@ func (s *serviceImpl) AcceptInvitation(ctx context.Context, networkID, email, hu } } - newMemberEmailPrefix := strings.Split(normalized, "@")[0] - _, err = s.aeroSvc.ShootEmail(ctx, &pbaero.ShootEmailRequest{ - ToEmails: emailRecipients, - Subject: fmt.Sprintf("A new member has joined %s", network.Name), - TemplateData: &pbaero.ShootEmailRequest_SimpleHtmlData{ - SimpleHtmlData: &pbaero.SimpleHtmlData{ - Html: buildNewMemberHTML(network.Name, newMemberEmailPrefix), + if len(emailRecipients) > 0 { + newMemberEmailPrefix := strings.Split(normalized, "@")[0] + _, err = s.aeroSvc.ShootEmail(ctx, &pbaero.ShootEmailRequest{ + ToEmails: emailRecipients, + Subject: fmt.Sprintf("A new member has joined %s", network.Name), + TemplateData: &pbaero.ShootEmailRequest_SimpleHtmlData{ + SimpleHtmlData: &pbaero.SimpleHtmlData{ + Html: buildNewMemberHTML(network.Name, newMemberEmailPrefix), + }, }, - }, - }) - if err != nil { - flog.Warn("unable to send email notification", "email", email, "network", network.Name) + }) + if err != nil { + flog.Warn("unable to send email notification", "email", email, "network", network.Name) + } } }